search

alanshaw / david-www

:eyeglasses: David helps keep your Node.js project dependencies up to date.
https://david-dm.org
MIT License
728 stars 131 forks source link

Internal Server error (500) instead of 404 for missing repo #336

Open XhmikosR opened 8 years ago

XhmikosR commented 8 years ago

So, say I use https://david-dm.org/appveyor/website it throws an internal server error.

The image works fine for the branch: dependencies Status.

Shouldn't this case be handled and not throw an HTTP Error 500?

alanshaw commented 8 years ago

Yes!

alanshaw commented 8 years ago

Closing as this issue seems to be fixed

XhmikosR commented 8 years ago

Well, unless you did something, it's not fixed. Simply put, the repo exists now and has a package.json thus you see no error.

alanshaw commented 8 years ago

Oh, apologies. So the problem is that the site returns a 5xx error for a 404 - https://david-dm.org/foo/bar

XhmikosR commented 8 years ago

Yup. :)

aeimer commented 7 years ago

I think the issue #366 handles the Same issue.

bonebizz21 commented 7 years ago

Yes

paulmelnikow commented 6 years ago

Hi there! Thanks so much for your work on this project. I don't like to post +1 comments because they are usually are noise, when a 👍 on the top comment does just as well. However, I wanted to convey that there is some ecosystem impact from this issue.

I'm a maintainer of Shields, https://shields.io/, which developed the badge standard and hosts standardized versions of many badges (about 450 million each month).

Because in the case of our David badge, we can't distinguish the "not found" case from a proper server error, we're unable to provide a helpful error message to the user. They are left wondering whether there might be some temporary downtime in David, or whether they've just misspelled the name of their project. When someone is setting up a new badge for their project, it's really common to run into typos along the way, which is why we work hard to provide good error messages.

I cloned the code and looked into this for about a half hour, but wasn't familiar with the dependencies you're using and wasn't able to solve the issue in that time.

Again, thanks so much for your work on this useful project! Really glad there is something free out here that does this. 😄