alanshaw / david-www

:eyeglasses: David helps keep your Node.js project dependencies up to date.
https://david-dm.org
MIT License
729 stars 131 forks source link

Badge status always "pending" when Git dependency present #368

Closed ssoloff closed 7 years ago

ssoloff commented 7 years ago

My David devDependency badge is always showing "pending" for one of my projects when I expect it to be "up to date" (yellow), based on the individual dependency statuses. Below is a screenshot demonstrating this issue (just in case my dependency status changes by the time someone can take a look):

david-dm-screenshot-with-pinned-git-version

My theory is that gulp-exclude-gitignore's Git dependency is causing the problem. To test this theory, I changed the dependency to the latest published version and checked David's status for this branch:

david-dm-screenshot-without-pinned-git-version

Is the "pending" badge by design? Or is it possible David has a problem generating the aggregate status when a Git dependency is present?

gregswindle commented 7 years ago

Issue summary

One of my repositories -- gregswinde/generator-android-lib -- has the same issue.

Expected Behavior

The David-DM badge for gregswinde/generator-android-lib's dependencies should read "dependencies | up to date" (in the green).

The badge for gregswindle/generator-android-lib displays correctly:

devDependencies Status

Current Behavior

The David-DM badge for gregswinde/generator-android-lib's dependencies displays as "pending," even though each package is "green" and up-to-date:

dependencies Status :arrow_left: select to view dependency list

Possible Solution

Unsure, sorry. :confused:

Steps to Reproduce (for bugs)

  1. Select the faulty badge for dependencies: dependencies Status
  2. Despite the badge's "pending" status, all dependencies are "up-to-date."

Context

Like @alanshaw, my project has (three top-level) internal Git dependencies:

  1. git-remote-origin-url: dependency
  2. github-usernam: dependency
  3. git-labelmaker: dev-dependency

Here are all nested packages (i.e., the output of tree -d):

mac-osx-chrome-v57.0.2987.133-packages.tree.txt

Environment

David-DM version:

https://github.com/gregswindle/generator-android-lib

alanshaw commented 7 years ago

Thanks for your patients. I believe this bug has been resolved in by https://github.com/alanshaw/david-www/commit/6436f07bec18384d0d83a8e89b7fb40286da5bc8. Please comment if you notice this issue again.

ssoloff commented 7 years ago

Thanks for following up on this, @alanshaw! I confirmed I no longer have a Pending dev dependency badge. However, all of my badges now show as Up to Date (Green), when they should all be Up to Date (Yellow) based on the individual dependency statuses. Is this just a caching issue (i.e. do I have to wait a bit longer)? Or possibly a different problem?

gregswindle commented 7 years ago

Thanks, @alanshaw! It's working for me, now (as the badges in my initial comment attests).

ericmorand commented 7 years ago

How can this issue be closed when it is visually obvious that it is not resolved?

alanshaw commented 7 years ago

Hi @ericmorand I'm just looking at this 11 minutes after you commented and your badges have already moved from pending to their appropriate states.

screen shot 2017-06-14 at 10 09 38
jeffminsungkim commented 6 years ago

I'm having the exact same issue right now. I think this issue has to be reopened.

alanshaw commented 6 years ago

@jeffminsungkim can you point me to your package.json?

jeffminsungkim commented 6 years ago

@alanshaw Not sure why, but the issue has been resolved.

johnnyBira commented 6 years ago

Got the same issue: https://david-dm.org/johnnyBira/responsive-props

sangaman commented 6 years ago

Same issue here: https://david-dm.org/sangaman/http-jsonrpc-server

deepsweet commented 6 years ago

Same here, package.json.

MrWook commented 6 years ago

Same here

Borewit commented 6 years ago

Same:

Repo badge
then-read-stream Dependencies
strtok2 Dependencies
strtok3 Dependencies
dnl1 commented 6 years ago

Same here

ralego75 commented 6 years ago

Same here, package.json

s-herbert commented 6 years ago

Samesies. 21 Dependencies total 21 Up to date 0 Pinned, out of date 0 Out of date

yet, "Pending"

ralego75 commented 6 years ago

image Yet pending ...

pedrowilkens commented 5 years ago

Same here devDependencies Status

and

dependencies Status

both sould be up to date

alanshaw commented 5 years ago
screenshot 2018-11-16 at 16 40 29

looks good to me...

jfoclpf commented 5 years ago

Didn't want to bother, but do you know how much time does it take to process? It's been 30 minutes already since I gave permissions and signup

In any case I read the disclaimer :)

David is currently BETA, which means it may be unreliable, unavailable or not working. That said, it's already useful and we're working to make it rock solid.

Thanks for the cool plugin

chrisweb commented 5 years ago

dependencies Status

problem seems to be back (>24h since update)

EDIT: seems it's fixed (14 minutes later) and it works for me EDIT2: now it's gray again, maybe not a bug, but a problem related to server load or something like that

Borewit commented 5 years ago

@alanshaw, can you please re-open? Issue is clearly not solved, still lots of gray badge icons.

effy-coding commented 5 years ago

same here