alanshaw / david-www

:eyeglasses: David helps keep your Node.js project dependencies up to date.
https://david-dm.org
MIT License
731 stars 131 forks source link

Optimize React for production #399

Closed blgm closed 6 years ago

blgm commented 6 years ago

What I don't like about these changes:

I'm happy to try and resolve these with some guidance as to what is preferred.

Testing:

alanshaw commented 6 years ago

The infrastructure project is here, I need to upgrade it to add letsencrypt support this week so I can also do the work to ensure NODE_ENV set to production in the same pass so lets leave it out of the package.json.

I'd appreciate it if you did also submit an updated package-lock.json I want to use a more recent Node.js in production so we'll need it, and it is in the repo now so we should at least keep it up to date.

alanshaw commented 6 years ago

Also, thanks ✨ @blgm ✨

blgm commented 6 years ago

@alanshaw, I've pushed some more changes which hopefully address your comments.