Closed blgm closed 6 years ago
The infrastructure project is here, I need to upgrade it to add letsencrypt support this week so I can also do the work to ensure NODE_ENV set to production in the same pass so lets leave it out of the package.json.
I'd appreciate it if you did also submit an updated package-lock.json
I want to use a more recent Node.js in production so we'll need it, and it is in the repo now so we should at least keep it up to date.
Also, thanks ✨ @blgm ✨
@alanshaw, I've pushed some more changes which hopefully address your comments.
process.env.NODE_ENV = 'production'
usingenvify
uglifyify
1028132
bytes to655814
(36%)What I don't like about these changes:
minify
phase)package.json
to get a development build (if we knew thatNODE_ENV
was always set toproduction
on the production server, then we could allowenvify
to pick it up from the environment, allowing development machines to have a development version of React)package-lock.json
as both.travis.yml
andpackage.json
suggest this is a node 6 project, which does not supportpackage-lock.json
by defaultI'm happy to try and resolve these with some guidance as to what is preferred.
Testing: