search

alanshaw / grunt-include-replace

Grunt task to include files and replace variables. Allows for parameterised includes.
MIT License
200 stars 45 forks source link

Remove hard version dependency for node engine #3

Closed nschonni closed 11 years ago

nschonni commented 11 years ago

Since 0.10 is out, the current setting will through warnings for users on the newer version.

alanshaw commented 11 years ago

Thanks nschonni, it definitely needs to be changed but I'd rather it referenced versions of node that grunt-include-replace is known to work with, rather than just ALL versions greater than 0.8.0 (including all future versions!).

Semver allows for version ranges so I'm thinking it should read "~0.8.15 || ~0.10.0" for now.

nschonni commented 11 years ago

Do what makes sense for you. I took this value as it seems to be the default for any of the Grunt 0.4+ contrib projects. Looking through the task though the only thing that you have Node dependencies on are path and fs. This may be able to be replaced with the grunt.file.* methods. That said, I know Grunt did have some issues after the 0.10 launch :smile:

alanshaw commented 11 years ago

I am possibly overly anal about this sort of thing - I've released v0.1.2 to NPM which should remove the warning on install. Thanks for pointing it out, I really appreciate it.

nschonni commented 11 years ago

No problem, you can put the "0.10" in you travis file if you want to be sure about the testing on the new platform. Make sure you use quotes though, otherwise it will get truncated to '0.1`

alanshaw commented 11 years ago

:thumbsup: