Closed alansk closed 11 years ago
tomelvidge
commented
11 years ago Ace!!
Tom Elvidge 917-331-8668
On Mar 1, 2013, at 5:19, Alan Skerrett notifications@github.com wrote:
Thoughts on this...
— Reply to this email directly or view it on GitHub.
tomelvidge
commented
11 years ago Couple of thoughts...
Tom Elvidge 917-331-8668
On Mar 1, 2013, at 5:19, Alan Skerrett notifications@github.com wrote:
Thoughts on this...
— Reply to this email directly or view it on GitHub.
alansk
commented
11 years ago -- can we make the buttons centred vertically in the menu bar? At the moment it's a bit higher than centre. For sure.
-- should we make the 'create' button orange like the one below? For sure.
-- can we make the text a little bit bigger? Slightly concerned about keeping longer menu items (i.e. some of the category names) from wrapping around onto a second line, but I'll go as big as I can.
tomelvidge
commented
11 years ago Awesome. Agreed lets go as big as poss on a single line.
Tom Elvidge 917-331-8668
On Mar 1, 2013, at 7:49, Alan Skerrett notifications@github.com wrote:
-- can we make the buttons centred vertically in the menu bar? At the moment it's a bit higher than centre. For sure.
-- should we make the 'create' button orange like the one below? For sure.
-- can we make the text a little bit bigger? Slightly concerned about keeping longer menu items (i.e. some of the category names) from wrapping around onto a second line, but I'll go as big as I can.
— Reply to this email directly or view it on GitHub.
alansk
commented
11 years ago Hmmm it's looking good, but doesn't work great on mobile (I knew there was a reason I kept avoiding doing this) so it's gonna take me some time to get the mobile version working decently.
tomelvidge
commented
11 years ago Is it possible to keep mobile as it is and only change non-mob?
Tom Elvidge 917-331-8668
On Mar 2, 2013, at 14:41, Alan Skerrett notifications@github.com wrote:
Hmmm it's looking good, but doesn't work great on mobile (I knew there was a reason I kept avoiding doing this) so it's gonna take me some time to get the mobile version working decently.
— Reply to this email directly or view it on GitHub.
tomelvidge
commented
11 years ago Sorry sent that before I'd looked on mob. I think it looks fine...
Tom Elvidge 917-331-8668
On Mar 2, 2013, at 14:41, Alan Skerrett notifications@github.com wrote:
Hmmm it's looking good, but doesn't work great on mobile (I knew there was a reason I kept avoiding doing this) so it's gonna take me some time to get the mobile version working decently.
— Reply to this email directly or view it on GitHub.
alansk
commented
11 years ago I haven't uploaded the changes yet
tomelvidge
commented
11 years ago Oh ok! :-)
Tom Elvidge 917-331-8668
On Mar 2, 2013, at 14:56, Alan Skerrett notifications@github.com wrote:
I haven't uploaded the changes yet
— Reply to this email directly or view it on GitHub.
alansk
commented
11 years ago Sorry, it was just a progress update :)
alansk
commented
11 years ago Okay please check out the live site and advise on any tweaks you think are necessary.
tomelvidge
commented
11 years ago Looked on mobile only but looks ace mate!!
Tom Elvidge 917-331-8668
On Mar 5, 2013, at 8:44, Alan Skerrett notifications@github.com wrote:
Okay please check out the live site and advise on any tweaks you think are necessary.
— Reply to this email directly or view it on GitHub.
tomelvidge
commented
11 years ago I think this looks fantastic. One small change - the user picture (in top right when logged in) is very small and hard to make out what it is. Can that be made bigger?
Otherwise I think it is great.
alansk
commented
11 years ago Cool, that should be resolved now, shall we close this?
tomelvidge
commented
11 years ago yeah let's!
On Wed, Mar 6, 2013 at 6:30 AM, Alan Skerrett notifications@github.comwrote:
Cool, that should be resolved now, shall we close this?
— Reply to this email directly or view it on GitHubhttps://github.com/alansk/TopTopFives/issues/139#issuecomment-14494715 .
alansk
commented
11 years ago Closing...
Thoughts on this...