search

alanvardy / tod

An unofficial Todoist command line client written in Rust
MIT License
104 stars 9 forks source link

Page size fix #805

Closed stacksjb closed 5 months ago

stacksjb commented 5 months ago

Fixing too large page size in terminal display when handing large lists/options.

I am still unsure of why in the code I need to do this (as it shouldn't be neccessary) but debugging shows the correct values and variables are coming through so fixing this for now as it passes all tests.

alanvardy commented 5 months ago

Oh, and I forgot, please add a line to the CHANGELOG.md describing the fix.

stacksjb commented 5 months ago

Updates made

stacksjb commented 5 months ago

Sorry for the gajillion reports. Learning how to do upstream -> downstream merge and resolve conflicts, and then needed to learn to get it to run rust-fmt locally. I think I have a good build submission process now! (Submitted another PR to handle some pre-commit tasks if possible, I can rebase it once this goes through)

alanvardy commented 5 months ago

Sorry for the gajillion reports. Learning how to do upstream -> downstream merge and resolve conflicts, and then needed to learn to get it to run rust-fmt locally. I think I have a good build submission process now! (Submitted another PR to handle some pre-commit tasks if possible, I can rebase it once this goes through)

No worries at all, I just periodically check my github notification in the web browser and don't let it notify me directly. So you do you!

I use a rebase workflow and keep amending the initial commit, which makes it a little easier for me as long as I keep the PR size low.

alanvardy commented 5 months ago

Needs a rebase and conflict resolution

image