search

alanwalk / markdown-toc

MarkdownTOC(Table Of Contents) Plugin for Visual Studio Code.
MIT License
141 stars 111 forks source link

Emoji should be removed from github.com anchor #31

Open kennytm opened 7 years ago

kennytm commented 7 years ago

Test case:

<!-- TOC updateOnSave:true -->

* [🚲 Hello 🚲](#🚲-hello-🚲)

<!-- /TOC -->

# 🚲 Hello 🚲

...

The generated anchor links to #🚲-hello-🚲, but on GitHub the actual anchor is #-hello-.

anoff commented 7 years ago

This seems to have been fixed in 0.5.7. Should also be autofixed as the semVer range defined in this package is ^0.5.6. Since the fix was provided ~20 days ago in the dependency I assume you (like me) have a version that's older than 20 days. A simple reinstall on the extension page however doesn't do the trick for me to get the dependencies upgraded. Might be a package-lockor similar. Just head over to the directory and force an update

cd ~/.vscode/extensions/AlanWalk.markdown-toc-*
npm i anchor-markdown-header@0.5.7
# restart code completely

You can confirm the dependency version (before or afterwards):

cat ~/.vscode/extensions/AlanWalk.markdown-toc-*/node_modules/anchor-markdown-header/package.json| grep version
mcornella commented 4 years ago

This can be closed once 1.6.0 is released (in the VS marketplace).