Use updated DynFlags after CPP phase. Fixes #25

alanz / ghc-exactprint

GHC version of haskell-src-exts exactPrint

BSD 3-Clause "New" or "Revised" License

70 stars 32 forks source link

Use updated DynFlags after CPP phase. Fixes #25 #26

Closed rubik closed 9 years ago

rubik commented 9 years ago

The change passes all the tests. Since they were probably passing before as well, you probably need more test cases for CPP. Tested with:

$ stack init
$ stack test

Note: Stack needs a stack.yaml file which is not present in the repository. I had to run stack init to create it. If you want I can submit a PR to add stack.yaml to the repo.

alanz commented 9 years ago

Can you explain what problem this change is trying to solve? Perhaps by referring to a failing test case in another project.

mpickering commented 9 years ago

https://github.com/alanz/ghc-exactprint/issues/25

mpickering commented 9 years ago

Thanks! I am going to revert the change to the phase flag but the rest looks good!