alanzanattadev / atom-docker

Docker Integration for Atom.io
MIT License
48 stars 11 forks source link

TypeError: Cannot read property 'map' of undefined #27

Open Xanagandr opened 7 years ago

Xanagandr commented 7 years ago

Trying to select or add a compose file yields the error:

Imposible to select compose file. TypeError: Cannot read property 'map' of undefined

maximkrusina commented 7 years ago

Same here... @Xanagandr - which version of docker-compose are you using? I have: version: '3.3'

Xanagandr commented 7 years ago

@maximkrusina Likewise

maximkrusina commented 7 years ago

So the bug is related to v 3.3 config. Just edited version 3.3 > 2 + removed this section (v3):

deploy:
 restart_policy:
    condition: on-failure

and it works, somehow...

maximkrusina commented 7 years ago

Plz also notice this...

screen_shot_2017-10-11_at_08_38_42

byoigres commented 6 years ago

This bug is because the code is validating only mayor versions and not minor, at least with version 0.8.0 of the package:

screen shot 2017-10-23 at 10 03 05
olamedia commented 5 years ago

Yes, please compare with major number somehow.

switch (version.split('.')[0]) or

let majorVersion = parseInt(version.split('.')[0], 10);
switch (majorVersion)

or

let floatVersion = parseFloat(version);
switch (floatVersion)