search

alaouy / YouTube

🔥 Laravel PHP Facade/Wrapper for the Youtube Data API
MIT License
778 stars 204 forks source link

PHP 8 Support #164

Closed C0kkie closed 3 years ago

C0kkie commented 3 years ago

This should hopefully add php 8 support

bzbislawski commented 3 years ago

I'm reluctant to add this to the repo. I does not provide any value. We don't use any PHP 8 features yet so no need to add it to composer. I suppose only travis changes are ok.

C0kkie commented 3 years ago

Its needed, cuz otherwise you cant use this package with php 8 cuz it requires php 7

bzbislawski commented 3 years ago

You are right. I confused it with >=7.0 :)

C0kkie commented 3 years ago

^^ so i think it should be enough