alar-dict / alar.ink

dictmaker site theme for alar.ink (Kannada-English dictionary)
https://alar.ink
MIT License
39 stars 12 forks source link

fix hyperlink formation of Kannada words #11

Closed gagantk closed 7 months ago

gagantk commented 8 months ago

Issue

The current logic (from the commit #5) misplaced the leading non-Kannada characters when forming the hyperlink for Kannada words.

Example

When there are leading non-Kannada characters in a Kannada word in the meaning definitions, the leading characters goes after the Kannada word when the hyperlink is formed. Below are some scenarios:

gagantk commented 7 months ago

Hi @knadh, is this change not deployed yet?

knadh commented 7 months ago

Hi @gagantk. This is now deployed.

gagantk commented 7 months ago

Hi @knadh, looks like it's not deployed yet. I don't see the change on the website. Can you please verify the deployment?

knadh commented 7 months ago

Ouch, I'd forgotten that the dictpress version alar.ink is running on is obsolete. The deployment didn't go through because it has a bunch of old dependencies that no longer worker properly.

The entire installation needs to be upgraded to the latest version, alongside upgrading the theme (this repo itself). I'll add this to my calendar for the coming week and re-deploy integrating your changes. Thanks for your patience.