Deprecation warnings for 4.2.0 not useful

alarm-redist / redist

Simulation methods for legislative redistricting.

https://alarm-redist.github.io/redist/

GNU General Public License v2.0

66 stars 23 forks source link

Deprecation warnings for 4.2.0 not useful #171

Closed christopherkenny closed 8 months ago

christopherkenny commented 11 months ago

Currently, they point to a whole different package, rather than pointing to the correct replacement.

Example:

ℹ In argument: `egap = partisan_metrics(map, "EffGap", rvote, dvote)`.
Caused by warning:
! 'partisan_metrics' is deprecated.
Use 'redistmetrics' instead.
See help("Deprecated")

This should point to part_egap(). It could be nice to also give some of the syntax, like part_egap(redist::pl(), map, rvote, dvote) since those can be inferred at that point.

CoryMcCartan commented 8 months ago

Can't infer map/shp object name, so just pointing people to the correct function(s)

Closed by ce17ec4