alarmz / boar

Automatically exported from code.google.com/p/boar
0 stars 0 forks source link

Unhandled Exception when Updating #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
When boar can't update a file, an unhandled exception occurs and stops the 
process.

What steps will reproduce the problem?
1. Attept to update a directory containing files with the System and Hidden 
attributes.
2. Observe the exception.

What is the expected output? What do you see instead?
I expect the action taken to be configurable, (ie. Can't update Thumbs.db, 
Skip/All/Ignore/Fail)

The Traceback is as follows:
Updating: photos/2009/100CANON/Thumbs.db
Traceback (most recent call last):
  File "C:\Python26\boar\boar", line 498, in <module>
    main()
  File "C:\Python26\boar\boar", line 470, in main
    cmd_update(args[1:])
  File "C:\Python26\boar\boar", line 280, in cmd_update
    wd.update(new_revision = options.revision)
  File "C:\Python26\boar\workdir.py", line 141, in update
    fetch_blob(front, b['md5sum'], target_abspath, overwrite = True)
  File "C:\Python26\boar\workdir.py", line 482, in fetch_blob
    f = open(target_path, "wb")
IOError: [Errno 13] Permission denied: 
u'E:\\Pictures\\photos/2009/100CANON/Thumbs.db'

What platform are you using? (Windows XP, Windows 7, Linux, ...)
Windows 7 Ultimate

What version of Python are you using?
Python 2.6.5

What version of boar are you using? (Mercurial change id or daily build date)
Daily Build 2/13

Original issue reported on code.google.com by fleeingt...@gmail.com on 21 Feb 2011 at 3:00

GoogleCodeExporter commented 9 years ago
Agreed. This needs to be handled more gracefully. I think a quick fix will be 
to add a "--force" option, to simply ignore all errors, to allow for a way to 
proceed for users bumping into this issue. Not so elegant, but it will at least 
be quick to implement. I'll also open a new issue regarding the best way to 
handle these kinds of errors.

Original comment by ekb...@gmail.com on 24 Feb 2011 at 3:01

GoogleCodeExporter commented 9 years ago
Fixed in changeset 296:a3acaa6dc936

There is now a --ignore option to 'update' that makes the process continue 
after errors. Also, any errors are presented in a nicer way (not as stack 
dumps). 

Please verify that the fix works.

Original comment by ekb...@gmail.com on 27 Feb 2011 at 4:26

GoogleCodeExporter commented 9 years ago
I'm currently on vacation, but I will have a chance to try the new fix
on Monday. Thanks!

Original comment by fleeingt...@gmail.com on 2 Mar 2011 at 2:13

GoogleCodeExporter commented 9 years ago
Assuming verified.

Original comment by ekb...@gmail.com on 20 Aug 2011 at 9:48