search

alarner / perk

A well documented set of tools for building node web applications.
http://perkframework.com
MIT License
181 stars 31 forks source link

Error in guide page for 'Creating a dynamic view with ejs' #101

Closed twgardner2 closed 6 years ago

twgardner2 commented 6 years ago

I apologize if this is the wrong place to bring this up, but I think there is a small error in the perk guide. The final example on the 'Creating a dynamic view with ejs' page, shows the escaped ejs tag where I think it should show the unescaped ejs tag: perk error

alarner commented 6 years ago

Hey @twgardner2 thanks for the bug report. I've got this on my todo list now, but might not fix for a few weeks because I've got a ton of other work. If you want to submit a PR this is where you can find that doc page: https://github.com/alarner/perk-docs/blob/master/src/v1/guides/creating-a-dynamic-view-with-ejs.md

Cheers!

twgardner2 commented 6 years ago

Great - I was having trouble finding that page of the docs. Single character PR submitted!

On Thu, May 10, 2018 at 3:15 PM, Aaron Larner notifications@github.com wrote:

Hey @twgardner2 https://github.com/twgardner2 thanks for the bug report. I've got this on my todo list now, but might not fix for a few weeks because I've got a ton of other work. If you want to submit a PR this is where you can find that doc page: https://github.com/alarner/ perk-docs/blob/master/src/v1/guides/creating-a-dynamic-view-with-ejs.md

Cheers!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alarner/perk/issues/101#issuecomment-388049909, or mute the thread https://github.com/notifications/unsubscribe-auth/AZNcJx4JCAGub6psNWABBfih8mKr1c6Pks5txD2LgaJpZM4T5aZB .

alarner commented 6 years ago

@twgardner2 merged and deployed! Thanks for the PR.