alarner / perk

A well documented set of tools for building node web applications.
http://perkframework.com
MIT License
181 stars 31 forks source link

email / password registration should not require firstname or lastname #14

Closed alarner closed 8 years ago

dominathan commented 8 years ago

From a cursory glances, it looks like you have notNullabe on firstName in your knex migrations

                 t.string('firstName').notNull();
        t.string('lastName').nullable();
        t.string('email').nullable();

Happy to take a stab at it. I've been using a pretty similar stack minus bookshelf so I'm happy to take a stab at some of these.

alarner commented 8 years ago

@dominathan Yes that would be awesome! There might also be some validation code in the routes/auth.js file for the .post('/register/ ...) but I can't quite remember, so maybe take a look in there too.

dominathan commented 8 years ago

Don't see any validators on firstname,lastname in the auth routes, nor in the UserModel

dominathan commented 8 years ago

Close that puppy out!

alarner commented 8 years ago

Thanks for your help!