search

alarner / perk

A well documented set of tools for building node web applications.
http://perkframework.com
MIT License
181 stars 31 forks source link

remove notnullable from user.firstName, user.lastNmae, make user.ema… #15

Closed dominathan closed 8 years ago

dominathan commented 8 years ago

Not sure if you want user.email to be nullable but I assumed even with oauth you would want to store users' emails.

alarner commented 8 years ago

@dominathan Some OAuth providers don't provide emails, so in order to accommodate I have to leave that email nullable and just enforce that it is set when using email / password authentication. The rest looks great though

dominathan commented 8 years ago

Makes sense

alarner commented 8 years ago

Looks great! Thanks for the help