alashow / datmusic

Search and download free music from VK.
https://datmusic.xyz
MIT License
231 stars 58 forks source link

The recoded/original bitrate and file size are inverted #24

Closed JanPokorny closed 7 years ago

JanPokorny commented 7 years ago

This is pretty confusing: image Anyway, keep up the good work! EDIT: Not even mentioning one says kbit and the other kbps

alashow commented 7 years ago

Hey.

I don't know why I did it "kbit" but I can remember why did I invert: to distinguish calculated value (guessing how big will be converted size and predicted bitrate of the original) and exact value.

Do people really find it confusing? I should change it if they are. Also, I need to remove ~ sign from both or only from original bitrate prediction, it's almost exact number anyways.

JanPokorny commented 7 years ago

I can't speak for others, but I find it confusing and believe others do too. I'm for unifying the bitrate/size order and removing the ~ sign -- that would make the dropdown more readable. Here's a quick mockup: image