search

alashworth / test-issue-import

0 stars 0 forks source link

Add vectorized signatures for RNGs #182

Open alashworth opened 5 years ago

alashworth commented 5 years ago

Issue by seantalts Wednesday Feb 14, 2018 at 18:11 GMT Originally opened as https://github.com/stan-dev/stan/issues/2467

Summary:

@bbbales2 added vectorized forms for a bunch of RNGs with these PRs: https://github.com/stan-dev/math/pull/605 https://github.com/stan-dev/math/pull/722. Now we can add their signatures to the language. We might do something in line with what happened in this vectorizing PR: https://github.com/stan-dev/stan/pull/2107 but they won't be unary, so that will be slightly more complicated.

Current Version:

v2.17.1

alashworth commented 5 years ago

Comment by roualdes Tuesday Feb 20, 2018 at 16:49 GMT

@seantalts I just submit a pull request for this issue, Feature/issue 2467 vectorized signatures rn gs, please review when convenient. Thank you.

alashworth commented 5 years ago

Comment by bob-carpenter Tuesday Feb 20, 2018 at 18:05 GMT

Thanks. I just reviewed.

alashworth commented 5 years ago

Comment by roualdes Thursday Aug 09, 2018 at 17:30 GMT

With https://github.com/stan-dev/stan/pull/2585, https://github.com/stan-dev/stan/pull/2583, https://github.com/stan-dev/stan/pull/2580, and https://github.com/stan-dev/stan/pull/2471 all merged, should we close this?

alashworth commented 5 years ago

Comment by bob-carpenter Friday Aug 10, 2018 at 10:30 GMT

Sure. We need a second issue for the versions that look like normal_rng(N, mu, sigma) to generate an array of N i.i.d. draws from a normal_rng(mu, sigma). Those should be really easy to add and test with C++11 lambdas able to bind normal_rng(mu, sigma) into a nullary functor that can be iterated N times.

On Aug 9, 2018, at 7:30 PM, Edward A. Roualdes notifications@github.com wrote:

With #2585, #2583, #2580, and #2471 all merged, should we close this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.