search

alashworth / test-issue-import

0 stars 0 forks source link

relax requirement on final / in include paths #183

Open alashworth opened 5 years ago

alashworth commented 5 years ago

Issue by bob-carpenter Tuesday Feb 20, 2018 at 18:19 GMT Originally opened as https://github.com/stan-dev/stan/issues/2472

Summary:

The include path mechanism currently appends the file name to the path, which requires the path to end in /. Instead, check if the path ends in a separator, and if not, add one.

@ahartikainen originally brought this up in: https://github.com/stan-dev/pystan/pull/438#issuecomment-367004027

Current Version:

v2.17.1

alashworth commented 5 years ago

Comment by bgoodri Wednesday Feb 21, 2018 at 02:17 GMT

Also, if it cannot find the #included file, the error message should reference the file name that it did not find.

alashworth commented 5 years ago

Comment by ariddell Saturday Mar 31, 2018 at 16:13 GMT

Should the milestone for this be bumped? This would be great to get in.

alashworth commented 5 years ago

Comment by ahartikainen Saturday Apr 28, 2018 at 08:53 GMT

Hi,

could the code also ignore whitespace before and after the statement?

E.g. https://stackoverflow.com/a/216883