search

alashworth / test-issue-import

0 stars 0 forks source link

parse integers in scientific notation out of dump format #28

Open alashworth opened 5 years ago

alashworth commented 5 years ago

Issue by bob-carpenter Friday Jan 17, 2014 at 21:23 GMT Originally opened as https://github.com/stan-dev/stan/issues/497

Improve the integer parser for the dump format to accept integers like 1e8 by noticing that they have no decimals in their mantissa.

It might be easiest to read them into double-precision floats, then cast to int.

We should also test for overflow in sizes while we still restrict to int.

alashworth commented 5 years ago

Comment by syclik Wednesday Nov 30, 2016 at 14:57 GMT

This should be an easy issue to pick off for someone that can read through src/stan/io/dump.hpp.

alashworth commented 5 years ago

Comment by bob-carpenter Wednesday Nov 30, 2016 at 20:09 GMT

Just need to get the ordering right so that the parser doesn't automatically assume something with an e in it is a double value.