reverse deprecation on abs() and fabs()

alashworth commented 5 years ago

Issue by bob-carpenter Wednesday Jan 28, 2015 at 22:54 GMT Originally opened as https://github.com/stan-dev/stan/issues/1255

I think we should deprecate

real fabs(real)

and go with just

real abs(real)
int abs(int)

The only drawback is that we won't have a function that applies to an integer and returns a real value, but I don't think we need that. Returning an integer won't lose information, and Stan will just promote it to a real value if necessary to use it elsewhere. And we'll still get integer absolute values for integers.

I propose getting rid of everything we're deprecating in Stan 3.

[ ] undeprecate abs(real)
[ ] deprecate fabs()
[ ] update manual explaing what's going on

alashworth commented 5 years ago

Comment by rtrangucci Friday Mar 04, 2016 at 23:09 GMT

@syclik we fixed with #1649 which was merged, ok to close?

alashworth commented 5 years ago

Comment by bob-carpenter Friday Mar 04, 2016 at 23:14 GMT

yes.

alashworth commented 5 years ago

Comment by bob-carpenter Monday Dec 12, 2016 at 02:37 GMT

I think we can solve this one and it'll be less confusing to users not familiar with the C++ function fabs.

alashworth / test-issue-import

reverse deprecation on abs() and fabs() #54