alastair / python-musicbrainzngs

Python bindings for Musicbrainz' NGS webservice
http://python-musicbrainzngs.readthedocs.io/
Other
274 stars 103 forks source link

remove PUID support #130

Closed JonnyJD closed 10 years ago

JonnyJD commented 10 years ago

PUIDs are now gone: http://blog.musicbrainz.org/2013/03/21/puids-are-deprecated-and-will-be-removed-on-15-october-2013/

So the PUID parts of our API should be removed from the documentation and we should "stub" them internally: Always returning empty sets or similar. Well, if we do want to silently not return anything or raise a specific warning is up for disscussion.

There will probably be no direct AcoustID support from the MB WS: http://tickets.musicbrainz.org/browse/MBS-6052

We might link to https://github.com/sampsyo/pyacoustid somewhere in the documentation.

alastair commented 10 years ago

Some libraries have an always-printed log message that says a method is deprecated. We could do that in the stub for 1 or 2 versions and then get rid of it.

On Tue, Nov 5, 2013 at 1:28 PM, Johannes Dewender notifications@github.comwrote:

PUIDs are now gone:

http://blog.musicbrainz.org/2013/03/21/puids-are-deprecated-and-will-be-removed-on-15-october-2013/

So the PUID parts of our API should be removed from the documentation and we should "stub" them internally: Always returning empty sets or similar. Well, if we do want to silently not return anything or raise a specific warning is up for disscussion.

There will probably be no direct AcoustID support from the MB WS: http://tickets.musicbrainz.org/browse/MBS-6052

We might link to https://github.com/sampsyo/pyacoustid somewhere in the documentation.

— Reply to this email directly or view it on GitHubhttps://github.com/alastair/python-musicbrainzngs/issues/130 .

JonnyJD commented 10 years ago

That would be similar to what I did here: JonnyJD/python-discid@efbfafa62772a848926f47e4d792e56a1d85b2a5 (or rather removed after the deprecation period).

JonnyJD commented 10 years ago

There even was a ticket for removing deprecating echoprints and PUIDs: #106

We really should start deprecating in 0.5. I'll see if I can fix something up these days.

JonnyJD commented 10 years ago

PR in #106