search

alastair / python-musicbrainzngs

Python bindings for Musicbrainz' NGS webservice
http://python-musicbrainzngs.readthedocs.io/
Other
274 stars 105 forks source link

Default to use MusicBrainz and CAA over HTTPS #245

Closed Freso closed 5 years ago

Freso commented 5 years ago

Adds new "global" https boolean variables. This variable will be True by default, but if set_hostname() gets called it will default to False. This should allow both using musicbrainz.org/coverartarchive.org over HTTPS by default, but anyone that have a script setting a custom server (that may not support HTTPS) will continue to work as well.

I didn't see anywhere to denote that Python 2.7.6 would be the minimal supported version for this (as per my comment: https://github.com/alastair/python-musicbrainzngs/issues/197#issuecomment-465531186).

Should resolve https://github.com/alastair/python-musicbrainzngs/issues/197

genodeftest commented 5 years ago

This solution looks very clean, minimal and backwards-compatible.

alastair commented 5 years ago

I've updated this, a revision by someone else would be welcome!