search

alastair / python-musicbrainzngs

Python bindings for Musicbrainz' NGS webservice
http://python-musicbrainzngs.readthedocs.io/
Other
274 stars 105 forks source link

Fix parsing of genres. #266

Open aereaux opened 4 years ago

aereaux commented 4 years ago

Currently they don't seem to get returned.

This was taken from #247

Signed-off-by: Aidan Epstein aidan@jmad.org

clang13 commented 3 years ago

What needs to happen to merge and release this PR? It does appear that genre support does not work without this fix.

alastair commented 2 years ago

Thanks for the start on this work! I made a small change to also include the genre id attribute

aereaux commented 2 years ago

Great, thanks for maintaining this! Anything else I'd need to do for it to be merged?

deckgamez commented 2 years ago

Any update to this one?

vinyllionel commented 2 years ago

@aereaux @alastair can one of you please fix ASAP? my grandfather just lost several evenings worth of manual tagging due to this issue and some tools that rely on these bindings.

i'm restoring from a backup from last monday, but that's still 18-20 hours of lost work.

please fix this, get the fix merged, and release a new version asap. this is causing data loss.

kongwak commented 2 years ago

Is there a release planned for this? It would be very nice have.

mtrolley commented 2 years ago

Any chance of this PR being merged soon? It's coming up on 2 years old.

Seqularise commented 2 years ago

here is a patched PKGBUILD with this for those who are on arch, quick solution until this will get merged https://pastebin.com/PK6VtyU7

kongwak commented 2 years ago

Is this going to make the next release of beets? As it stands, there a no very reliable options for adding genres in beets.

mtrolley commented 2 years ago

Is this going to make the next release of beets? As it stands, there a no very reliable options for adding genres in beets.

It would need to be merged and a new tag created.

vinyllionel commented 2 years ago

Hi @alastair, can you merge this? We're only a few months away from this being 2 years old.

calm3285 commented 11 months ago

this issue is 3 years old