Wait for GetOrAddAsync factory to return before reading from AbsoluteExpirationRelativeToNow

alastairtree / LazyCache

An easy to use thread safe in-memory caching service with a simple developer friendly API for c#

https://nuget.org/packages/LazyCache

MIT License

1.71k stars 159 forks source link

Closed allanrodriguez closed 3 years ago

allanrodriguez commented 3 years ago

Fixes #148.

In GetOrAddAsync, addItemFactory is now awaited before SetAbsoluteExpirationFromRelative is called. This eliminates the race condition where SetAbsoluteExpirationFromRelative reads from ICacheEntry.AbsoluteExpirationRelativeToNow before it is set to, in cases where AbsoluteExpirationRelativeToNow is set after a long-running task in the factory completes.
Added unit tests.

alastairtree commented 3 years ago

Awesome thanks