Update geth options - Githubissues

alastria / alastria-node-quorum

How to install a node in Alastria Red-T (GoQuorum Technology) and tips to deploy and use it

Apache License 2.0

4 stars 3 forks source link

Update geth options #29

Closed irzinfante closed 2 years ago

irzinfante commented 2 years ago

Adaptación y actualización de las opciones de geth para la versión 21.1.0 de GoQuorum:

Completamos las opciones para conexiones HTTP/WS en los nodos regulares
Establecemos miner.gastarget (8M gas) y miner.gaslimit (10M gas) en los nodos validadores
Añadimos el nombre del nodo en el bloque generado (valor extradata/vanity del bloque) con miner.extradata
Añadimos opciones para monitorización con prometheus/grafana en validadores y bootnodes
Eliminamos opción targetgaslimit (mal utilizada y deprecada)
Quitamos las opciones para las métricas de los archivos de configuración incorrectos
Actualizamos readme

carlosho17 commented 2 years ago

in regular nodes we might want for members: METRICS="--metrics --metrics.expensive --pprof --pprofaddr=0.0.0.0"

Beware that in 21.10.0 pprofaddr turns into pprof.addr METRICS="--metrics --metrics.expensive --pprof --pprof.addr=0.0.0.0"

We could have separate jobs in Prometheus to scrape separately and have different tables in dashboard for bootnodes, validators and regulars

irzinfante commented 2 years ago

Agreed. We can use also Prometheus/Grafana for regular nodes instead of ethstats.

Also, in the main branch we will keep using GoQuorum v21.1.0, so no problem with incompatible options names for higher versions.

hesusruiz commented 2 years ago

We should use this opportunity to remove all deprecated parameters and start using the proper ones. For example, the --rpc family have to be converted to --http and this applies to:

--rpc --rpcaddr 0.0.0.0 --rpcport 22000 --rpccorsdomain "*" --rpcvhosts "*" --rpcapi

Which sould be:

--http --http.addr 0.0.0.0 --http.port 22000 --http.corsdomain "*" --http.vhosts "*" --http.api

irzinfante commented 2 years ago

We are still using GoQuorum version 21.1.0. In this versión --rpc family is correct as --http family is still not defined. We can make different branches for higher GoQuorum versions with updated options.

Other deprecated options have been updated.

hesusruiz commented 2 years ago

We are still using GoQuorum version 21.1.0. In this versión --rpc family is correct as --http family is still not defined. We can make different branches for higher GoQuorum versions with updated options.

Other deprecated options have been updated.

Sorry, I got confused with the brach that we will create for migration to 21.10.x