search

alastria / alastria-wallet

Wallet of ALASTRIA_ID
12 stars 16 forks source link

Added build instructions for Ubuntu 16.04 and Docker #77

Closed muisit closed 3 years ago

muisit commented 4 years ago

This PR adds a doc directory containing build instructions for a basic Ubuntu 16.04 LTS platform.

It also contains a Dockerfile that sets up a build environment for the wallet based on the Ubuntu 16.04 instructions, containing an entry point script that allows the user to execute various build commands at the installed toolset (npm, ng, ionic). Using this docker, users can easily build Android files based on the wallet configurations. I did not test this for XCode compatibility.

Work gratefully sponsored by SURFnet, Netherlands, https://surf.nl

VictorNS69 commented 3 years ago

Hi @muisit we would like to know if the issues you ask in this PR are already fixed.

If you consider that there are still some issues to be corrected, please let us know.

If there is no more activity in this PR we will close it soon.

muisit commented 3 years ago

This PR is about extending the Alastria code base with documentation about installing and building the project on Ubuntu 16, including a Dockerfile build file to create a containerised build environment. There are no 'issues to be fixed'. The only thing this PR fixes is 'missing documentation for building using Ubuntu 16'.

I don't think #78 fixes anything that coincides with this PR. The only minor element that coincides with #78 is the fact that 'npm install' is being run. There is no other similarity at all. I don't know why 'rdemera' tagged this PR, but probably because he saw that amongst the changes an 'npm install' was found. Whatever #78 fixes, it does not overlap with this PR.

I no longer have the opportunity to work on Alastria at the moment, so I cannot assist in updating or adjusting this PR any further. If you do not think it is worthwhile to add to the code base, please remove it.