alateeq99 / linux-syscall-support

Automatically exported from code.google.com/p/linux-syscall-support
0 stars 0 forks source link

Update MIPS support #4

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
While adding MIPS support to breakpad I came across a few problems with the 
current version of lss support:

* LSS_ERRNO may involve a function call so LSS_RETURN must preserve $v0 value
* syscall clobbers $25/t9
* __v0 needs "+r" constraint when it contains the system call number
* Simplified and made consistent the O32 versions of syscall5/syscall6
* __r7 needs "+r" constraint in clone syscall
* __r7/__v1 need "+r" constraint in pipe syscall

Original issue reported on code.google.com by chris.jw...@gmail.com on 12 Apr 2012 at 8:43

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for this patch. I don't actually have access to MIPS hardware, so I 
can't easily test the changes, but they do look correct as far as I can tell by 
reading the source code.

I applied them to the source repository.

https://chromiumcodereview.appspot.com/10067027

Original comment by markus@chromium.org on 13 Apr 2012 at 1:32

GoogleCodeExporter commented 8 years ago
It seems like the breakpad project is pulling this file from 
http://linux-syscall-support.googlecode.com/svn
Is it possible to get this change committed there as well?

Thanks
Chris

Original comment by chris.jw...@gmail.com on 18 Apr 2012 at 8:27

GoogleCodeExporter commented 8 years ago
I am puzzled what you are asking for. If I look at 
http://linux-syscall-support.googlecode.com/svn/trunk/lss/linux_syscall_support.
h the patch does in fact appear to be life. What am I missing?

Original comment by markus@chromium.org on 18 Apr 2012 at 8:37

GoogleCodeExporter commented 8 years ago
Yes you're right. I don't see this change when I checkout the breakpad sources 
but I guess it must be using a particular revision. I'll take it up there.
Thanks

Original comment by chris.jw...@gmail.com on 25 Apr 2012 at 10:43