search

albaintor / integration-kodi

Kodi integration for Unfolded Circle Remote Two
Mozilla Public License 2.0
7 stars 1 forks source link

Add additional buttons and change number keys #2

Closed klada closed 7 months ago

klada commented 7 months ago

This supersedes #1

@albaintor You mentioned in #1 that some keys did not work for you. If BACK and ENTER did not work they can safely remain in keyboard mode - they also work for me this way. However the number keys don't work as expected in keyboard mode as they cannot be used for character input that way. However that's the usual way for people to type in text from a remote.

Out of curiosity: are you using an official Kodi build? What is your device? Do you have any custom keymaps in your userdata directory? I have just checked my userdata and there is no special configuration on my side.

albaintor commented 7 months ago

Hi, I will test your PR tomorrow (away from home). My device is Nvidia Shield Pro (2019) with official Kodi version (Omega 21). But I did my tests with the same kodi version running on my PC

klada commented 7 months ago

There is one thing that comes to my mind if you are having issues with this. Maybe you are using the Kodi addon peripheral.joystick? This might mess up keymaps. If you do you can try to disable it for testing and report back. Then we need to find out how we can make the remote work for users of this addon and for users who are not using this addon.

albaintor commented 7 months ago

Hi, I have tested your R1 commands for digits and this does not work on my side : I tested them on my nvidia shield and pc zero gives me '.', one => 'a', two => 'd', three => 'g'. Test done : go to file or library, raise context menu > rename, that brings virtual keyboard, then type a mapped digit I guess this is related to keyboard layout (azerty on my side) but I can't take this part of the PR as the actual implementation works for all keyboard layouts

I don't know if something could be done to raise alpha keys from the digits press. Maybe with long press

albaintor commented 7 months ago

I applied you PR fully finally, thanks. But one needs to investigate about the digit/alpha cycle. Doesn't seem to be possible through RPC JSON