search

albandechasteigner / GeniusLociForDynamo

Genius Loci is a package of 350+ custom nodes for Dynamo in Revit.
MIT License
45 stars 10 forks source link

Create Tag, Revit 2023 #21

Closed Plarmindo closed 1 year ago

Plarmindo commented 1 year ago

Hi Alban, first of all, thanks for sharing all your nodes, they are excellent. I have been testing rebar on Revit 2023, and your node for creating tags doesn't work with rebar. Is this something that you are available to fix?

Regards

Paulo Lima

albandechasteigner commented 1 year ago

Hi Paulo, There was a change in the Revit 2023 API for rebars. By the way, the OOTB Tag.ByElement nodes haven't been updated and don't work either. You are lucky because I saw this change yesterday and fixed it. The updated node can be donwloaded and the old node replaced in C:\Users\%USERNAME%\AppData\Roaming\Dynamo\Dynamo Revit\2.16\packages\Genius Loci\dyf (You need to click the Raw button and right click save as to properly download the custom node.) Best regards,

Plarmindo commented 1 year ago

Hi, Alban, wonderful that you already fixed it, thank you very much. The OOTB Tag.ByElement nodes are poor compared to yours. This morning I tried the OOTB nodes and noticed they were not working too.

Regards Paulo Lima

bminkov97 commented 1 year ago

Hi Alban, Great work! I have tried tagging the rebars in my slab but it seems that the rebar element I selected does not have the GetSubelements attribute (you use it at line 239 of your code). I tried it with PathReinforcement element and it does not seem to work. Any ideas?

Thanks in advance Regards Boris M

bminkov97 commented 1 year ago

@albandechasteigner