albandechasteigner / GeniusLociForDynamo

Genius Loci is a package of 350+ custom nodes for Dynamo in Revit.
MIT License
43 stars 9 forks source link

Wall CompoundStructureLayersLocation returns list of nulls in R2023 #27

Closed rvida5 closed 11 months ago

rvida5 commented 11 months ago

To start, thank you for the awesome package!

I've used your "Wall CompoundStructureLayersLocation" node successfully in the past, but I am now getting an issue in Dynamo Revit 2.16.1.6510. I was initially using version 2022.7.5 of the package, but then updated to the latest version 2023.7.13 and in both cases I get the same null result. Are you aware of any issues with this node in the most recent versions of dynamo? I feel like I've used it successfully in Revit 2023 before but this may be the first time I'm running it in 2023.1.

Thank you for your time!

image

albandechasteigner commented 11 months ago

Hi,

I'm glad you find the genius Loci package useful. In Revit 2023, you must install the DynamoIronPython2.7 package for the Genius Loci package nodes to work normally. (By default, it is now the CPython3 engine which is installed by default in Dynamo for Revit 2023.)

rvida5 commented 11 months ago

Hi Alban,

I currently have the latest version of the DynamoIronPython2.7 package installed (see image). It doesn't seem that is the problem.

image

albandechasteigner commented 11 months ago

Hi,

I confirm that the node works with Revit 2023. image

I see that you have 1294 walls. Try with just a few hundred walls to see if it works.

rvida5 commented 11 months ago

Thanks for the suggestion. I tried it on smaller and smaller lists of walls until I was able to narrow down the problem, it looks like there were some curtain walls included in the selection and that appears to cause an error with the node that prevents it from providing any results, even for the non curtain walls. Now that I know that's the reason, the solution is easy enough, I'll just update the graph to specifically filter out curtain walls... or filter out anything other than basic walls. Thanks!