search

albandechasteigner / GeniusLociForDynamo

Genius Loci is a package of 350+ custom nodes for Dynamo in Revit.
MIT License
45 stars 10 forks source link

View CropBox does not handle ViewType.Detail #28

Closed jake1108 closed 9 months ago

jake1108 commented 1 year ago

I just discovered that within the View CropBox node, that it could not handle my detail views.

Upon investigation it seems that the node does not have a condition to catch views of the type ViewType.Detail.

The three conditions are: if view.ViewType == ViewType.FloorPlan or view.ViewType == ViewType.CeilingPlan or view.ViewType == ViewType.EngineeringPlan : elif view.ViewType == ViewType.Section or view.ViewType == ViewType.Elevation : elif view.ViewType == ViewType.ThreeD:

I added or view.ViewType == ViewType.Detail: to row 58 and the node works.

albandechasteigner commented 9 months ago

Hi Jake,

Thanks for adding. I will publish an update to the package.