RFG "search again" continues search where it left previously

albar965 / littlenavmap

Little Navmap is a free flight planner, navigation tool, moving map, airport search and airport information system for Flight Simulator X, Microsoft Flight Simulator 2020, Prepar3D and X-Plane.

https://albar965.github.io/littlenavmap.html

GNU General Public License v3.0

1.23k stars 161 forks source link

RFG "search again" continues search where it left previously #1146

Closed u-an-i closed 3 weeks ago

albar965 commented 3 weeks ago

FYI: I am looking at MainWindow::routeNewFromAirports() since it deletes user made changes in the current plan and drops them from the undo stack. Also leaves two entries in the undo stack for departure and destination. Everything else is works perfectly. :+1: Alex

u-an-i commented 3 weeks ago

Hi @albar965 ,

do you mean ?

I added this because of this comment: in search::airportsearch.cpp

I always got the nagging dialog and it disrupted my experience.

Do you want me to do something ?

albar965 commented 3 weeks ago

Do you want me to do something ?

Nope. I'm about done changing this. The experience should be the same as when using the route description dialog window where no nagging appears at and all changes saved to the undo/redo stack. This avoids data loss for the user.

albar965 commented 3 weeks ago

The idea is:

Load a plan.
Change it.
Start random generation.
Accept flight. No nagging dialog.
Undo 1 -> Back to changed flight before random.
Undo 2 -> Back to unchanged flight as loaded

albar965 commented 3 weeks ago

5e758fd001e21f4bb8bf104a744fdace30f28237 Looking ok so far. BTW: State of the random distance is saved here.

u-an-i commented 3 weeks ago

looks appropriate.