search

albermax / innvestigate

A toolbox to iNNvestigate neural networks' predictions!
Other
1.25k stars 233 forks source link

Version 1.0.9 update #222

Closed enryH closed 3 years ago

enryH commented 3 years ago
enryH commented 3 years ago

In relevance_rule.py new alpha-beta-rules are introduced in Feb. 2019. Is there any reference?

"AlphaBetaXRule",
"AlphaBetaX1000Rule",
"AlphaBetaX1010Rule",
"AlphaBetaX1001Rule",
"AlphaBetaX2m100Rule"
enryH commented 3 years ago

v1.0.9 is now on test.pypi.org for testing.

albermax commented 3 years ago

Yes, if it is not used I would remove it.

On Fri, Sep 25, 2020 at 11:54 AM Henry notifications@github.com wrote:

@enryH commented on this pull request.

In .github/workflows/pythonapp.yml https://github.com/albermax/innvestigate/pull/222#discussion_r494879944:

  • uses: actions/setup-python@v1
  • with:
  • python-version: ${{ matrix.python-version }}
    • name: Install dependencies
  • run: |
  • python -m pip install --upgrade pip
  • pip install .
  • pip install tensorflow==${{matrix.tensorflow-version}} matplotlib
    • name: Lint with flake8
  • run: |
  • pip install flake8

  • stop the build if there are Python syntax errors or undefined names

  • flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics

  • exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide

  • flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

  • or pylint?

So you suggest removing the flake8 part?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/albermax/innvestigate/pull/222#discussion_r494879944, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBDPJ5RX4BIKBBF6NYLHD3SHRSGZANCNFSM4RTQNJXA .

-- Cheers, Max