search

albertarielw / pe

0 stars 0 forks source link

NFR #2 is not reasonably achieved #15

Open albertarielw opened 2 years ago

albertarielw commented 2 years ago

Expected: Based on NFR #2, "Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage."

Actual: Noticable lags for some commands such as undo even for 20 persons/ properties

image.png

nus-se-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thanks for raising the issue! Our team believed that the NFR of 1000 people being added to the application is a reasonable NFR, and could not reproduce the noticeable lag mentioned even with 1500 properties and clients in our application. The undo command is likely slower than other commands due to the large size of the PropertyDirectory and ClientDirectory, but it seems reasonably fast within the response time of 1 second. In the example below, I try editing and deleting clients, and undoing the changes I made was reasonable fast, despite the large number of clients.


video:https://raw.githubusercontent.com/nus-cs2103-AY2223S1/pe/master/files/5bb3639c-b318-45ea-96b7-2dec59b50a0f.mp4

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: [replace this with your reason]