albertarielw / pe

0 stars 0 forks source link

Inconsistent Index Error Message #2

Open albertarielw opened 1 year ago

albertarielw commented 1 year ago

Steps to reproduce: Enter: delete -p abc delete -p 0 delete -p 10 (assuming there are less than 10 properties)

Expected: delete -p 0 should have the same error message as delete -p 10

Actual: delete -p 0 has the same error message as delete -p abc

Effect: Cause user some confusion on how to debug their commands. This indicates wrong exception detection.

Screenshot

image.png

image.png

image.png

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

bug(error): Wrong Error Message

User should get "Wrong index", but got "Wrong command format" instead

image.png


[original: nus-cs2103-AY2223S1/pe-interim#5747] [original labels: type.FunctionalityBug severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Clearly stated in the error message that index must be a positive integer (1,2,3,...). Therefore, this is an invalid command

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is a bug in your code since your program does not recognize the right error


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]