search

alberthaff / ngx-papaparse

Papa Parse wrapper for Angular
https://alberthaff.dk/projects/ngx-papaparse/docs/v8
MIT License
90 stars 19 forks source link

Adds generic type to PapaParse to allow for typing of returned parsed… #104

Closed olivermchale closed 1 year ago

olivermchale commented 1 year ago

… data

Couldn't see any contribution/testing guidelines - let me know if anything needs updating! thanks

alberthaff commented 1 year ago

Hi, thanks for the PR!

I think we should change the default type from unknown to any in order to avoid breaking changes. Besides that, it looks good.

olivermchale commented 1 year ago

Hi @alberthaff - I've updated this now. Thanks!

alberthaff commented 1 year ago

Thanks