alberthaff / ngx-papaparse

Papa Parse wrapper for Angular
https://alberthaff.dk/projects/ngx-papaparse/docs/v8
MIT License
90 stars 19 forks source link

Angular 15 Ivy Engine #113

Closed acasanova99 closed 1 year ago

acasanova99 commented 1 year ago

This is just a suggestion:

After updating an Angular Project from v14 to v15 I get the following warning:

Processing legacy "View Engine" libraries:
- ngx-papaparse [es2015/esm2015] (https://github.com/alberthaff/ngx-papaparse)
Encourage the library authors to publish an Ivy distribution.

As detailed here, Ivy is going to be the only available Engine for Angular.

In your application's tsconfig.json file, remove enableIvy. In v15, Ivy is the only rendering engine so enableIvy is not required.

It is possible that in future versions of Angular this will cause some errors.

SamScholefield-open200 commented 1 year ago

When updating did you manually uninstall your current version of papaparse and reinstall using npm install ngx-papaparse@7 --save?

Fresh install with 15 and I see no legacy engine warnings...

alberthaff commented 1 year ago

@SirSkizo Please provide an exact angular and library version.

acasanova99 commented 1 year ago

I was using Angular v15.0.2 with ngx-papaparse@4.0.4.

Running npm install ngx-papaparse@7, solves the issue.

It would be good to have a table of versions. In the readme or in the documentation page to avoid this kind of issues. Anyway, I am sorry to annoy you with version issues.

alberthaff commented 1 year ago

No worries. It's stated in the beginning of the readme on GH, NPM and on the docs website.