search

alberthaff / ngx-papaparse

Papa Parse wrapper for Angular
https://alberthaff.dk/projects/ngx-papaparse/docs/v8
MIT License
90 stars 19 forks source link

Angular 7 Update #30

Closed pantonis closed 5 years ago

pantonis commented 6 years ago

Can you please update to Angular 7

alberthaff commented 5 years ago

Yes I will upgrade to Angular 7, but I am a little pressed for time at the moment. Are there any issues using ngx-papaparse@3.0.0 with NG 7?

rayzru commented 5 years ago

AFAIK, using ngx-papaparse for 2 weeks causes no issues at all at NG7. It's just throwing those warnings.

npm WARN ngx-papaparse@3.0.0 requires a peer of @angular/common@^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-papaparse@3.0.0 requires a peer of @angular/core@^6.0.0 but none is installed. You must install peer dependencies yourself.

Just tested it with NG7.0.4. & TS3.1.4

alberthaff commented 5 years ago

@rayzru Thanks. I'll get that fixed.

shyamal890 commented 5 years ago

+1

alberthaff commented 5 years ago

The warning should be gone, as of version 3.0.1