search

alberthaff / ngx-papaparse

Papa Parse wrapper for Angular
https://alberthaff.dk/projects/ngx-papaparse/docs/v8
MIT License
90 stars 19 forks source link

Type definitions are incorrect #54

Closed OrangeDog closed 1 year ago

OrangeDog commented 4 years ago

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/papaparse/index.d.ts is correct.

This module has, for example, dynamicTyping?: boolean; even though the accompanying doc comment specifies it can also be an object or folder.

alberthaff commented 4 years ago

Hi. Thanks for pointing this out. Feel free to create a PR - and i'll be happy to merge it in.

OrangeDog commented 4 years ago

Would it work if you removed it completely added a dependency on @types/papaparse?

alberthaff commented 4 years ago

Yeah, I think so. This should also lead to less maintenance, since this plugin basically pass the options array to Papa Parse. Most new functions will probably just require that the types and Papa Parse itself are updated.

Please note that the setters and getters for chunkSize, etc. are camelCase in the Papa-service. They are a bit mixed in Papa Parse.

alberthaff commented 1 year ago

Closing due to inactivity. Feel free to reopen.

OrangeDog commented 1 year ago

Inactivity doesn't make it less of a problem.