alberthaff / ngx-papaparse

Papa Parse wrapper for Angular
https://alberthaff.dk/projects/ngx-papaparse/docs/v8
MIT License
90 stars 19 forks source link

CommonJS or AMD dependencies can cause optimization bailouts #70

Open malcomm opened 4 years ago

malcomm commented 4 years ago

Angular 10 is now throwing this warning:

WARNING in /someproject/node_modules/ngx-papaparse/__ivy_ngcc__/fesm2015/ngx-papaparse.js depends on 'papaparse/papaparse.min.js'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Just wanted to put this on your radar.

See: https://web.dev/commonjs-larger-bundles/

alberthaff commented 4 years ago

Hi.

Unfortunately, i can't really do anything about that for now.

The problem is with the underlying library. For more information, see https://alberthaff.dk/projects/ngx-papaparse/docs/v5/installation/angular-10-or-later

jweisman commented 3 years ago

Looks like this is being worked on: https://github.com/mholt/PapaParse/pull/875