alberti42 / Volume-Control

Successor of iTunes Volume Control
GNU General Public License v3.0
210 stars 9 forks source link

Compatibility with new macOS 12.2 native Music App #11

Open derstrassi opened 2 years ago

derstrassi commented 2 years ago

Doesn't seem to work with the Beta 2 version of the macOS 12.2 native Music App. Checked all permissions twice.

alberti42 commented 2 years ago

Thank you for the feedback. I won't be able to test it on the beta version but I will certainly do it once the new version is released. In case the problem persists, I will release a fix.

Best regards Andrea

Am 25.01.2022 um 13:40 schrieb derstrassi @.***>:

Doesn't seem to work with the Beta 2 version of the macOS 12.2 native Music App. Checked all permissions twice.

— Reply to this email directly, view it on GitHub https://github.com/alberti42/Volume-Control/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPC4BDOPZGCT6XTNBDVMDUX2K5TANCNFSM5MYEVTDA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.

0x42h commented 2 years ago

Hi @alberti42,

Nice work. Thanks. Almost works on 12.3 here. I compiled my own, also, to give it another go for Music volume but without avail, unfortunately.

What works?

All these options, with the exception (but can most probably be ignored) the "invert behavior of ⌘ modifier key".

image

Step size also works.

image

Why can we probably ignore the fact of the behavior of the ⌘ modifier key?

Sound control for Music doesn't work at all. I can see the volume percentage of Music, strangely enough, however.

image

Since I'm a developer (albeit not savvy on macOS software), do you have any pointers on where potentially solve this issue? Might you wanna meet and talk about; feel free to contact me. Happy to help.

Best, B

PS O my, Qauntum Physics -- don't meet with me -- we might get stuck in an infinite loop -- o, wait -- maybe we already are... ;-)

0x42h commented 2 years ago

And then I changed the target platform to 12.3 in XCode. Then I tried to run that. That froze my screen (couldn't click anything and had to reboot, pressing the power button for 8 seconds, or so). Then, after reboot, I ran it again and it magically started working. No idea what I did. Any questions or remarks?

Seems I'm not using my own compiled version now, but yours, so the target platform isn't it (wasn't expecting that to begin with, but was just diggin' around). However, I think I might have found the difference, as I added the app to this category, which, obviously, makes sense?

image
alberti42 commented 2 years ago

Hi 0x42h,

I would love to help you but I am not sure I understand sufficiently the situation. I am running MacOS 12.3.1 and all functionalities seem to work on my computer. For the button inverting the behavior, it is maybe not clear what is meant to do. When this is selected, then one control the Apple Music volume with "apple cmd"+"volume keys", while one still controls the system volume when pressing the "volume keys". Normally, when this is not selected, it is the other way round.

Have you checked that the app has sufficient permissions to control the volume of Apple Music? It uses Apple Events under hood.

But as you said that you are willing to check the code, one of the important functions is

CGEventRef event_tap_callback(CGEventTapProxy proxy, CGEventType type, CGEventRef event, void *refcon)

in AppDelegate.m. You can add some commands like NSLog(@"This comment was triggered... or whatever info you like"); printing out something when parts of the code have been reached. The function is triggered when certain keys (the volume keys) are pressed. From there you see what other functions are triggered when you press volume down or volume up.

It is probably not a good idea to put a breakpoint in this function, because there is the risk that your keyboard becomes non responsive. In fact, until this function is not finished, keyboard events are not further processed. But maybe breakpoints work... try this out but be ready to restart your computer if you cannot use the keyboard anymore.

Let me know how this goes.

Best Andrea

Am 14.05.2022 um 13:26 schrieb 0x42h @.***>:

Hi @alberti42 https://github.com/alberti42,

Nice work. Thanks. Almost works on 12.3 here. I compiled my own, also, to give it another go for Music volume but without avail, unfortunately.

What works?

All these options, with the exception (but can most probably be ignored) the "invert behavior of ⌘ modifier key".

https://user-images.githubusercontent.com/24974331/168423567-5f9dcba4-49e8-443b-8184-5f28a1a9f243.png Step size also works.

https://user-images.githubusercontent.com/24974331/168423611-c4563134-89db-4048-a7dc-7ef6b9199d01.png Why can we probably ignore the fact of the behavior of the ⌘ modifier key?

Sound control for Music doesn't work at all. I can see the volume percentage of Music, strangely enough, however.

https://user-images.githubusercontent.com/24974331/168423595-c138b9df-e561-491d-bf62-e79706473a26.png Since I'm a developer (albeit not savvy on macOS software), do you have any pointers on where potentially solve this issue? Might you wanna meet and talk about; feel free to contact me. Happy to help.

Best, B

— Reply to this email directly, view it on GitHub https://github.com/alberti42/Volume-Control/issues/11#issuecomment-1126694925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPC4FFFMZGQ4XG2VVXRCDVJ6EXFANCNFSM5MYEVTDA. You are receiving this because you were mentioned.