alberti42 / Volume-Control

Successor of iTunes Volume Control
GNU General Public License v3.0
208 stars 9 forks source link

Some organisational remarks #5

Open tbussmann opened 3 years ago

tbussmann commented 3 years ago
alberti42 commented 3 years ago

the restoration of compatibility with older versions os macOS isn't mentioned in the Sparkle Release Notes nor in the "Versions" section of README.md (but it is mentioned under "Requirements") I did not mention it because I did not test it. I only enabled the compilation option. In some old versions, I created the graphics appearing when changing the volume by myself to reproduce the style of MacOS. I don't remember after what upgrade, but then MacOS started to show translucent effects. I then used directly a function of the operating system to recreate that. This might break compatibility with earlier versions. I had somewhere some virtual machines with some old mac installation, but I cannot find them anymore. There is too much overhead for me to maintain back compatibility with previous versions of MacOS. I was hoping that it would simply work, but I admit it was very naïve. There are no release tags on GitHub to match released binaries with their source version There seem to be two links to the latest version: http://quantum-technologies.iap.uni-bonn.de/alberti/iTunesVolumeControl/iTunesVolumeControl-v1.7.0.zip http://quantum-technologies.iap.uni-bonn.de/alberti/iTunesVolumeControl/iTunesVolumeControl-v1.7.0.zip and https://raw.githubusercontent.com/alberti42/Volume-Control/main/Volume%20Control.zip https://raw.githubusercontent.com/alberti42/Volume-Control/main/Volume%20Control.zip - the former encapsulates the app in an pkg while the second does not. The app payload is identical. Further, the ZIP and PKG of the first download is still called "iTunesVolumeControl" Yes, this was a work around to allow people to download the app with a new name. Sparkle library used to update versions seems to offer little support for changing the name of the application. But yes, the payload is the same. The move to a new GitHub repository confused me (and causes a loss of all the history) - why didn't you just rename https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/renaming-a-repository the exiting repo? Well, I did not know it was possible. But even so, I am not sure it was a good idea to break external links to "iTunes Volume Control" by renaming that page. But I cannot exclude there was a way to create an alias for redirecting, which I did not know about. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alberti42/Volume-Control/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPC4B2RYL5IZT7DHNSPWLTUQ7IFANCNFSM47JOSH6A.

jorisw commented 3 years ago

If I may add to this already misc thread:

alberti42 commented 3 years ago

Thank you for the suggestions. I will include them in the next update.

Am 27.07.2021 um 13:09 schrieb Joris W @.***>:

 If I may add to this already misc thread:

Would be best to link to this repository in the About dialog instead of to your email. This way, users can easily add (or find known) issues. Would be better if the Close menu item was called Quit like with other apps. Close implies it's still running after. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jorisw commented 2 years ago

To add to my previous copy remarks:

image

First item here should be called "Hide menu bar icon" Second item should be called "Hide volume feedback bezel"