plugin can install, but gives error. menu command to delete file is not present.

ksdavidc commented 8 hours ago

If I install, the plugin is present, but not active. menu command to delete file is not present.
If I try ot activate it I get a message saying it failed to load.
If I go to the plugin info page I can load the plugin in, it shows as being active, and see the settings, but I get an error message. menu command to delete file is not present.
However, if i reload the vault, the plugin is inactive again!

I am sure it is a plugin conflict but I have too many to troubleshoot right now. If you have any clue that might help me find the culprit that would be nice.

SYSTEM INFO: Obsidian version: v1.7.6 Installer version: v1.7.5 Operating system: Darwin Kernel Version 23.6.0: Mon Jul 29 21:13:00 PDT 2024; root:xnu-10063.141.2~1/RELEASE_X86_64 23.6.0 Login status: not logged in Language: en Insider build toggle: off Live preview: on Base theme: dark Community theme: AnuPpuccin v1.5.0 Snippets enabled: 13 Restricted mode: off Plugins installed: 272 Plugins enabled: 134 1: Callout Suggestions v1.0.2 2: Admonition v10.3.2 3: Advanced Tables v0.22.1 4: Another Quick Switcher v12.1.0 5: Automatic Table Of Contents v1.4.0 6: Better Command Palette v0.17.1 7: Better Export PDF v1.9.2 8: Better footnote v1.0.1 9: BRAT v1.0.5 10: CardBoard v0.7.9 11: Change Case v2.0.128 12: Doubleshift v2.2.1 13: Colored Tags Wrangler v0.19.3 14: Commander v0.5.2 15: Convert url to preview (iframe) v0.5.0 16: Copy document as HTML v0.8.1 17: Crumbs v0.1.2 18: Dataview v0.5.67 19: Easy toggle sidebars v2.0.1 20: Advanced URI v1.44.2 21: Copilot v2.7.2 22: Advanced Paste v2.7.0 23: Control Characters v0.3.0 24: Zoom v1.1.2 25: Editing Toolbar v2.4.16 26: Enhanced tables v1.0.5 27: Export Image plugin v2.3.13 28: Extract url content v0.12.1 29: File Tree Alternative v2.6.0 30: Find & Replace in Selection v1.1.0 31: Folder Note Core v1.3.5 32: Footnote Shortcut v0.1.3 33: Get Info v1.1.0 34: HelpMate v1.0.11 35: Hide Sidebars on Window Resize v1.1.0 36: Hover External Link Plugin v1.0.0 37: Hyphenation v0.1.0 38: Image in Editor v2.2.6 39: Key-Value List v1.7.0 40: Lapel v0.1.5 41: Links v1.17.25 42: Linter v1.27.1 43: Local File Interface v0.1.0 44: Local Images Plus v0.15.9 45: Local REST API v2.5.4 46: Merge Notes v0.0.9 47: Markdown Table Editor v0.3.1 48: Style Settings v1.0.9 49: Open with v0.3.2 50: Translate v1.4.9 51: Toggle Case v1.1.0 52: Tidy Footnotes v0.1.2 53: Theme Toggler v1.0.1 54: Theme Picker v1.0.8 55: Text Transporter v1.0.12 56: Text Snippets v0.1.2 57: Text Format v3.1.0 58: Text Extractor v0.5.2 59: Text expand v0.11.4 60: Templater v2.9.1 61: Tasks Calendar Wrapper v0.3.1 62: Tasks v7.13.0 63: Task Collector (TC) v1.1.5 64: Tag Wrangler v0.6.1 65: Tag Project v0.9.0 66: Table of Contents v0.2.0 67: Paste URL into selection v1.7.0 68: PDF break page v1.0.0 69: Snippetor v0.4.5 70: Size History v1.0.0 71: Show Current File Path v0.5.2 72: Sheets Extended v1.2.10 73: Share Note v0.8.17 74: Scratchblocks v0.0.1 75: Reveal Active File Button v2.0.3 76: Reset Font Size v1.0.2 77: Regex Find/Replace v1.2.0 78: QuickAdd v1.11.3 79: Quick Tagger v2.2.3 80: Quick Switcher++ v4.6.2 81: Quick Explorer v0.2.11 82: Projects v1.17.4 83: Plugin Update Tracker v1.6.0 84: Plugin Groups v2.1.0 85: Pluck v1.0.1 86: Outliner.md v0.1.9 87: floating toc v2.4.7 88: Kanban v2.0.51 89: Excalidraw v2.6.7 90: Outline Converter v1.3.2 91: Digital Garden v2.57.2 92: Datepicker v0.3.24 93: Natural Language Dates v0.6.2 94: MySnippets v1.2.3 95: Note Refactor v1.8.2 96: Edit mode switch v0.0.4 97: Tagged Documents Viewer v1.0.2 98: Tag Summary v2.1.5 99: Number Headings v1.16.0 100: Slides Extended v2.1.3 101: Plugins Annotations v1.7.8 102: Scroll to Top v2.1.4 103: Query Control v0.6.0 104: Auto Embed v1.2.4 105: Settings Management v1.0.5 106: Plugin Manager v0.1.5 107: Share my plugin list v0.3.3 108: Sort & Permute lines v0.7.0 109: Icon Shortcodes v0.9.7 110: Pane Relief v0.5.6 111: Emoji Toolbar v0.4.1 112: Table Generator v1.4.1 113: Hover Editor v0.11.21 114: Settings Search v1.3.10 115: Calendar v1.5.10 116: CardNote v1.2.0 117: Enhance YouTube Links v1.0.8 118: PDF++ v0.40.13 119: Better PDF 2 v2.0.3 120: Hotkey Helper v0.3.20 121: Strange New Worlds v2.1.5 122: Nav Link Header v1.0.3 123: Copy Section v1.1.2 124: Replace All v1.0.5 125: Editing Mode Hotkey v1.0.0 126: Heading Shifter v1.6.1 127: Various Complements v10.0.3 128: Omnisearch v1.25.1 129: CSV Table v1.2.0 130: Markdown Attributes v1.2.2 131: Find Orphaned Images v1.0.0 132: Lemons Search v0.0.7 133: Broken Links v1.2.2 134: Import Attachments+ v1.5.11

RECOMMENDATIONS: Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets. Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.

alberti42 commented 8 hours ago

Hi David, thanks for the report! Sorry it is not working. Let's try to find out why.

I am not sure I will be able to easily understand from the .log file where it breaks. Could you replace the file main.js in the folder <YOUR_VAULT>/.obsidian/plugins/import-attachments-plus with the one uploaded
here? I believe the main.js you have is in the "production" version and therefore javascript-minified, which makes it not easy to understand where it breaks when you open it. However, if you open the file I provided, the code is clear.

You can then run your test and reproduce the error. Once the error pops up, it would be great if you could click on the error itself from the Obsidian console. You should see a link. It should take you to the lines of code where the code breaks. It would be helpful for me to know what function and line the code breaks in. So if you could take a screenshot, that would be really helpful.

ksdavidc commented 32 minutes ago

Here is the new console log with the links.

I am not sure which one you want me to follow.

Some point to the lines in your main.js file, aka the "VM372..." entries.

But, there are several "links" here (e.g. to anonymous functions, of the form. app:js:1, but with the actual would-be "line number" missing, Do you need me to collect these as well?

app.js:1 Plugin failure: import-attachments-plus TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at updateVisibilityAttachmentFolders (VM372 plugin:import-attachments-plus:1195:14)
    at patchFileExplorer (VM372 plugin:import-attachments-plus:1224:5)
    at eval (VM372 plugin:import-attachments-plus:1840:7)
    at t.onLayoutReady (app.js:1:2158231)
    at ImportAttachments7.onload (VM372 plugin:import-attachments-plus:1839:24)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
app.js:1 Plugin failure: import-attachments-plus TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at updateVisibilityAttachmentFolders (VM437 plugin:import-attachments-plus:1195:14)
    at patchFileExplorer (VM437 plugin:import-attachments-plus:1224:5)
    at eval (VM437 plugin:import-attachments-plus:1840:7)
    at t.onLayoutReady (app.js:1:2158231)
    at ImportAttachments7.onload (VM437 plugin:import-attachments-plus:1839:24)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
Promise.then
l @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
e.enablePluginAndSave @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
t.onClick @ app.js:1
app.js:1 Plugin failure: import-attachments-plus TypeError: Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at updateVisibilityAttachmentFolders (VM437 plugin:import-attachments-plus:1195:14)
    at patchFileExplorer (VM437 plugin:import-attachments-plus:1224:5)
    at eval (VM437 plugin:import-attachments-plus:1840:7)
    at t.onLayoutReady (app.js:1:2158231)
    at ImportAttachments7.onload (VM437 plugin:import-attachments-plus:1839:24)
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
s @ app.js:1
Promise.then
l @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
e.enablePluginAndSave @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
g @ app.js:1
(anonymous) @ app.js:1
(anonymous) @ app.js:1
t.onClick @ app.js:1

The first app:js:1 goes to:

            e.prototype.enablePlugin = function(e, t) {
                return void 0 === t && (t = !1),
                g(this, void 0, Promise, (function() {
                    var n, i;
                    return y(this, (function(r) {
                        switch (r.label) {
                        case 0:
                            if (!(n = this.manifests[e]))
                                return [2, !1];
                            if (this.isDeprecated(n))
                                return new HL("Unable to load plugin ".concat(n.name, " v").concat(n.version, ". This version has been reported to cause issues. Please check for a newer version of the plugin.")),
                                [2, !1];
                            if ("sliding-panes-obsidian" === n.id)
                                return new HL(createFragment((function(e) {
                                    e.createEl("p", {
                                        text: "As of Obsidian v1.0, Sliding Panes is a built-in feature called Stacked Tabs. We recommend uninstalling the Sliding Panes plugin."
                                    }),
                                    e.createEl("p").createEl("a", {
                                        cls: "mod-cta",
                                        text: "Learn more",
                                        href: "https://help.obsidian.md/User+interface/Stacked+tabs",
                                        attr: {
                                            target: "_blank"
                                        }
                                    })
                                }
                                )),6e3),
                                [2, !1];
                            if ("better-pdf-plugin" === n.id && "1.4.0" === n.version)
                                return new HL("Better PDF Plugin is no longer functional. We recommend uninstalling it.",6e3),
                                [2, !1];
                            if (!Pl.isDesktopApp && n.isDesktopOnly)
                                return [2, !1];
                            r.label = 1;
                        case 1:
                            return r.trys.push([1, 3, 4, 5]),
                            this.loadingPluginId = e,
                            [4, this.loadPlugin(e, t)];
                        case 2:
                            return r.sent(),
                            this.loadingPluginId = null,
                            [3, 5];
                        case 3:
                            return i = r.sent(),
                            this.loadingPluginId = null,
                            new HL(Ef.interface.msgFailedToLoadPlugin({
                                plugin: e
                            })),
                            console.error("Plugin failure: " + e, i),
                            [2, !1];
                        case 4:
                            return K_("communityPlugins.".concat(e)),
                            [7];
                        case 5:
                            return [2, !0]
                        }
                    }
                    ))
                }
                ))
            }

The last goes to:

            t.prototype.onClick = function() {
                this.disabled || this.setValue(!this.getValue())
            }

ksdavidc commented 20 minutes ago

alberti42 / obsidian-import-attachments-plus

plugin can install, but gives error. menu command to delete file is not present. #13