albertito / chasquid

SMTP (email) server with a focus on simplicity, security, and ease of operation [mirror]
https://blitiri.com.ar/p/chasquid/
Other
868 stars 56 forks source link

When set to "", some config options use the default value instead #25

Closed bbusse closed 2 years ago

bbusse commented 2 years ago

The 'drop_characters' config option defaults to 'drop_characters: "."' but when left empty (drop_characters: "") still drops the '.'

albertito commented 2 years ago

Thanks for reporting this! I just edited the title since this bug can be generalized to many of the config options.

Description

When a configuration option is set to "", chasquid will use the default value instead of the empty string.

In particular, the drop_characters and suffix_separators options are both affected.

Workaround

Until a fix is implemented, instead of using "", use any value that isn't found in the user part of addresses, like "🐞".

albertito commented 2 years ago

Commit 1741ff536be6cdbd378f2d9f91fc406a2b22f9e6 should fix this problem, and @bbusse kindly confirmed it works for them (thanks!).

It's currently in next, and as usual I will let it sit there for a bit in case something comes up before moving it to master, but it will definitely be included in the next release.

albertito commented 2 years ago

The fix is included in the v1.9 release.

Thanks again for reporting this!