Use configured hostname for outgoing mail SMTP banner

albertito / chasquid

SMTP (email) server with a focus on simplicity, security, and ease of operation [mirror]

https://blitiri.com.ar/p/chasquid/

Other

868 stars 56 forks source link

Use configured hostname for outgoing mail SMTP banner #8

Closed ThinkChaos closed 4 years ago

ThinkChaos commented 4 years ago

Chasquid was using the email's domain which isn't always correct, so we might as well use the config's hostname :)

albertito commented 4 years ago

Thank you for sending this!

Also, very weird timing: I fixed this 2 days ago in commit 13ee3ba4 :S

It's still not in the "master" branch as I wanted to give it some more live tests before setting the commit in stone, but so far it seems to be working fine.

I think it does the same thing as this patch, so I'd be inclined to close the merge request, but please let me know if there's anything you think is missing.

Thanks a lot! Alberto

ThinkChaos commented 4 years ago

Wow that's a funny coincidence. I forgot to check the next branch.

You're right I'll go ahead and close this!