search

albertlauncher / albert

A fast and flexible keyboard launcher
https://albertlauncher.github.io
Other
7.2k stars 304 forks source link

Input background color not changing #1431

Open f0s3 opened 2 weeks ago

f0s3 commented 2 weeks ago

Package source

aur, package named albert

App logs

17:48:37 [crit:albert.qml] QColor input_background_color QVariant(QColor, QColor(ARGB 1, 1, 1, 1))

there are more variables that report critical variables as well, so I'd assume that is not the only variable that doesn't set.

Current Behavior

I'm using i3wm with xorg on arch linux. When I change qml boxmodel property named Input Backgound Coloir in settings > window, it doesn't apply.

Expected Behavior

Expecting this propoerty to apply.

Anything else?

I'm using Widgets BoxModel for now, even though it doesn't give such customizations and has rounded corners which allows for seeing the window background which is black. Using albert with QML BoxModel with white background is unusable for me, because it's too bright. Here's a screenshot showing Widgets BoxModel that I currently use (you can notice the corners are black). I'd much rather deal with corners, than the white background. 2024-08-30_17:54:59

f0s3 commented 2 weeks ago

If main is the latest branch I can work off, I may try to look into it myself. Will just fork the repo, branch off from main in my fork, if I manage to fix it - will create a PR into your main. @ManuelSchneid3r What do you think?

f0s3 commented 2 weeks ago

I'm not usually coding in cpp, but I looked into the code anyway, and it seems to me that I found where to look at. There is a file called propertyeditor.cpp, now I need to somehow debug what is happening there (maybe put a std::cout, or find a way to attach a debugger).

As soon as I open the style editor, there are a bunch of identical errors, basically for every property in the DefaultStyle.qml. 2024-08-31_14:05:25

I'm currently building from source and launching.

Let me know if you happen to know how do I debug this or maybe yoou know some more info on what is causing these errors.

I will keep you updated on my progress.

ManuelSchneid3r commented 2 weeks ago

accitentially answered in telegram

f0s3 commented 2 weeks ago

Ok, but there is no customization on Widgets BoxModel. Will there ever be something like that? I'm not using a compositor, so rounded corners are displayed as black ones. If it were square it'd be fine by me. Btw, I don't know who you were talking to in telegram, cause I didn't receive any messages :) I'm @f0s30n3 in tg.

ManuelSchneid3r commented 2 weeks ago

Comments on github are relayed to the community chat.

There are theme files. But they are going to vanish in the future because I will drop the entire use of Qstylesheets because they don't work well with Qstyle

ManuelSchneid3r commented 2 weeks ago

You could just copy an existing theme and drop the border-radius as an intermediate solution