albertodemichelis / squirrel

Official repository for the programming language Squirrel
http://www.squirrel-lang.org
MIT License
913 stars 156 forks source link

Did I disprove the theory? #212

Closed ondkeso closed 4 years ago

ondkeso commented 4 years ago

I manage to assert false in the destructor of SQSharedState where it states: https://github.com/albertodemichelis/squirrel/blob/cd6f60867717f84bb3cf913c0c4000279f1ff789/squirrel/sqstate.cpp#L198

rversteegen commented 4 years ago

...how?

ondkeso commented 4 years ago

Hmmm, sadly I'm guessing nothing was proved. We had some other issues at the time which seemed to boil down to unsafe multithreading, so that probably borked up the gc chain somehow. Though I do wonder what theory is proved by that assert. The code just below suggests that there used to be additional gc cleaning required which is now unnecessary, or rather we'd assert false if the additional cleaning is still needed. Any thoughts @rversteegen?

albertodemichelis commented 4 years ago

Yep, that theory seems to be correct. I never managed to break it... but you never know.