search

albertodonato / query-exporter

Export Prometheus metrics from SQL queries
GNU General Public License v3.0
436 stars 101 forks source link

fix columns names in InvalidResultColumnNames being reported the wrong way round #185

Closed andrewjw closed 7 months ago

andrewjw commented 7 months ago

Hi,

The parameters for InvalidResultColumnNames are (expected, got), but they are called as (result_keys, expected_keys). This leads to a slightly confusing error message if you get your query wrong.

Hope this is useful!

Andrew

albertodonato commented 7 months ago

Nevermind, I've pushed a commit with that change (also fixing a failing test).

albertodonato commented 7 months ago

Thanks for reporting and fixing the issue!