albertogoffi / toradocu

Toradocu - automated generation of test oracles from Javadoc documentation
Other
42 stars 21 forks source link

Not null support and fixed goal files #102

Closed khaeghar closed 7 years ago

khaeghar commented 7 years ago

the problem is due to the matching in the subject part.

So, the parameter is predicates.

args[0] distance is 0, but also target.getPredicates() [Predicates] has distance 0 with "predicates"

So Toradocu gets both translations of the subject, adding them in the translation with an or connector, producing the bad translation.

2017-04-04 14:15 GMT+02:00 Alberto Goffi notifications@github.com:

@albertogoffi requested changes on this pull request.

This pull request includes many commits already merged in the master branch. It's better to close it and create a new one more clean and specific of the new changes.

In src/test/java/org/toradocu/PrecisionRecallCommonsCollections4.java https://github.com/albertogoffi/toradocu/pull/102#discussion_r109644931:

}

@Test public void testAllPredicate() throws Exception {

  • test("org.apache.commons.collections4.functors.AllPredicate", 1, 0.75, 1, 0, 1, 1);
  • test("org.apache.commons.collections4.functors.AllPredicate", 1, 0.75, 0.333, 0.333, 1, 1);

In this test and in testAnyPredicate, the precision decreases from 1 to 0.333, meaning that Toradocu produces incorrect translations. Can you explain the problem, please? Do you think we can address it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/albertogoffi/toradocu/pull/102#pullrequestreview-30758876, or mute the thread https://github.com/notifications/unsubscribe-auth/AU0fSP2v25Ik8z5T3ircP8brgDLp8R9Wks5rsjRJgaJpZM4Myuv1 .

albertogoffi commented 7 years ago

This pull request has been integrated into the master branch as #103.